Add projection v1.2.0 to the list of schema URIs in projection.py #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The migration of projection to latest version systematically pops the field epsg. If extension URI is pointing to versions 1.0.0 or 1.1.0, it is also changed to point to version 2.0.0. However, if schema URI is v1.2.0 the extension schema URI is not changed. I propose to change it as well in that case so that the change is explicit for all versions < 2.0.0. That would help finding out that a change occurred.
floriandeboissieu
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1590 +/- ##
==========================================
- Coverage 92.32% 92.30% -0.02%
==========================================
Files 55 55
Lines 8381 8387 +6
Branches 966 970 +4
==========================================
+ Hits 7738 7742 +4
Misses 457 457
- Partials 186 188 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gadomski
requested changes
Oct 21, 2025
Member
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
Makes sense to me, and could you add a simple regression test? The code in
pystac/tests/extensions/test_projection.py
Lines 577 to 594 in 065a631
Member
|
@gadomski I went to add a test and ended up adding a little logic to handle that v1.2.0 release jussssttt in case. |
Member
|
@floriandeboissieu hope you don't mind that I pushed to your branch. This one looked close to done so I just added a test to get it all the way there. |
gadomski
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The migration of projection to latest version systematically pops the field epsg. If extension URI is pointing to versions 1.0.0 or 1.1.0, it is also changed to point to version 2.0.0. However, if schema URI is v1.2.0, the extension schema URI is not updated. Although it is not necessary to validate items as both properties
proj:codeandproj:epsgare authorized in that v1.2.0, I propose to update it as well to v2.0.0 when migrating so that the change is explicit for all versions < 2.0.0. That would help finding out that a change occurred without having to inspect all assets.PR Checklist:
pre-commit run --all-files)pytest)